Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getAccountBalance() API. #2930

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Add getAccountBalance() API. #2930

merged 6 commits into from
Jul 10, 2024

Conversation

psybers
Copy link
Contributor

@psybers psybers commented Jun 23, 2024

Closes #2189 by adding a getAccountBalance() API function that takes the account ID as first argument, and an optional date cutoff (for finding balances on previous days).

@github-actions github-actions bot changed the title Add getAccountBalance() API. [WIP] Add getAccountBalance() API. Jun 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 23, 2024 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 3da3615
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/668ee81a2f0e7c0008333070
😎 Deploy Preview https://deploy-preview-2930.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@psybers psybers changed the title [WIP] Add getAccountBalance() API. Add getAccountBalance() API. Jun 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2024 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.96 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/narrow.js 76.72 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.5 kB 0%
static/js/wide.js 272.7 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 3.21 MB 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2024 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB → 1.13 MB (+343 B) +0.03%
Changeset
File Δ Size
packages/api/methods.ts 📈 +138 B (+1.02%) 13.19 kB → 13.33 kB
packages/loot-core/src/server/api.ts 📈 +194 B (+1.02%) 18.59 kB → 18.78 kB
packages/loot-core/src/server/main.ts 📈 +367 B (+0.60%) 59.67 kB → 60.03 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.13 MB → 1.13 MB (+343 B) +0.03%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

joel-jeremy
joel-jeremy previously approved these changes Jul 4, 2024
View reviewed changes
@youngcw youngcw added the ⚠️ Changes requested Pull Request needs changes before it can be reviewed again label Jul 8, 2024
@github-actions github-actions bot removed the ⚠️ Changes requested Pull Request needs changes before it can be reviewed again label Jul 10, 2024
@psybers psybers requested a review from MatissJanis July 10, 2024 19:38
MatissJanis
MatissJanis approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for working on all these API improvements!

@MatissJanis MatissJanis merged commit 3be7dd7 into actualbudget:master Jul 10, 2024
20 checks passed
@github-actions github-actions bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review labels Jul 10, 2024
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Closed
2 tasks
@youngcw
Copy link
Member

youngcw commented Jul 10, 2024

Did this get added to the docs? I don't see a PR for it

@psybers
Copy link
Contributor Author

psybers commented Jul 10, 2024

@youngcw No, I think the docs were not updated yet.

@psybers psybers mentioned this pull request Jul 10, 2024
Merged
@psybers
Copy link
Contributor Author

psybers commented Jul 10, 2024

See: actualbudget/docs#403

youngcw pushed a commit to actualbudget/docs that referenced this pull request Jul 12, 2024
@psybers
Add getAccountBalance() API documentation (#403)
ba2f767 
Docs for actualbudget/actual#2930.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatissJanis MatissJanis MatissJanis approved these changes

@joel-jeremy joel-jeremy joel-jeremy left review comments

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] API call for getting account balance
4 participants
@psybers @youngcw @MatissJanis @joel-jeremy